QueryBuilder does not add params for Expression in where case

[Tigrov]

It does not work if I pass params to new Expression()

AR::find()->where(new Expression(':item = ANY (array)', ['item' => 'value']))->all();

but it works if I pass params to where()

AR::find()->where(new Expression(':item = ANY (array)'), ['item' => 'value'])->all();

sometimes it is not comfortable when I pass where expression as parameter of function or method

function getAll($where) {
    return AR::find()->where($where)->all();
}

// it does not work
$models = getAll(new Expression(':item = ANY (array)', ['item' => 'value']));

This can be fixed if to add one more condition in QueryBuilder::buildCondition()
https://github.com/yiisoft/yii2/blob/master/framework/db/QueryBuilder.php#L910

if ($condition instanceof Expression) {
    foreach ($condition->params as $n => $v) {
        $params[$n] = $v;
    }
    return (string) $condition;
}

Also it requires for QueryBuilder::buildAndCondition() and QueryBuilder::buildNotCondition()
https://github.com/yiisoft/yii2/blob/master/framework/db/QueryBuilder.php#L975
https://github.com/yiisoft/yii2/blob/master/framework/db/QueryBuilder.php#L1004
to replace if (is_array($operand)) { on if (is_array($operand) || $operand instanceof Expression) {

[klimov-paul]

I don't get it: what is the sense of passing Expression instance to Query::where(), while you can use a plain string for this?

AR::find()->where(':item = ANY (array)', ['item' => 'value'])->all();

[mnvx]

This situation described by Tigrov:

sometimes it is not comfortable when I pass where expression as parameter of function or method

function getAll($where) {
return AR::find()->where($where)->all();
}

And I agree with him. Sometimes it is handy to prepare where condition dynamically as a single object. In this case code where($expression) is more handy when where($expression->expression, $expression->params).
And if Expression using in some methods of QueryBuilder, it is good decision go use it in where(). Isn't it?

[klimov-paul]

Resolved by commit bea90e1