fix in log migration logic #12133
fix in log migration logic #12133
Conversation
bumstik
commented
Aug 10, 2016
bumstik
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | yes/no |
| Tests pass? | yes/no |
| Fixed issues | #11573 |
samdark
added
type:bug
|
День добрый. |
|
Пока нет. PR запланирован на следующий milestone |
|
Thank you for putting effort in the improvement of the Yii framework. In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests. Could you add these please? Thanks! P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests This is an automated comment, triggered by adding the label |
|
@bumstik вы желаете продолжить работу над этим пул-реквестом? |
|
Про тесты вышла ошибка. Тут они не нужны. |
|
Привет! |
|
CHANGELOG. |
|
Получилось три коммита, сойдет? |
|
@bumstik Нормально. При слиянии можно все три коммита в один объединить. |
…m141106_185632_log_init` that would create a log table correctly
|
Merged in 3ea6714 with some adjustments. Thank you. |
* master: (54 commits) Suggest latest PHP 7 usage in the guide [skip ci] Update .travis.yml Update .travis.yml travis_retry for mysql Fixes yiisoft#13401: Fixed lack of escaping of request dump at exception screens Added support for field `yii\console\controllers\BaseMigrateController::$migrationNamespaces` setup from CLI Adjusted changelog docs/guide-ja some files updated [ci skip] (yiisoft#13396) Revert "Fixed some comment issues (yiisoft#13392) [skip ci]" Fixes yiisoft#11464: Foreign key name is not provided by schema Removed unused method Exposed number normalization as StringHelper::normalizeNumber() Fixes yiisoft#13287: Fixed translating "and" separator in `UniqueValidator` error message Fixes yiisoft#12133: Fixed `getDbTargets()` function in `yii\log\migrations\m141106_185632_log_init` that would create a log table correctly Fixed some comment issues (yiisoft#13392) [skip ci] Fixed typos in docs/internals/core-code-style (yiisoft#13391) [skip ci] fixed some links in doc (yiisoft#13390) Used is_subclass_of() as suggested by @SamMousa Fixes yiisoft#13387: Extracted "Custom validator for multiple attributes" into community cookbook Updated travis config to build only on master branches ...
