Fix russian translation #13372
Closed
Fix russian translation #13372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jetexe
commented
Jan 11, 2017
jetexe
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes |
| Fixed issues | #13287 |
samdark
requested changes
Jan 11, 2017
| { | ||
| if (is_null($twoWordsConnector)) { |
There was a problem hiding this comment.
Better to use $twoWordsConnector === null.
cebe
approved these changes
Jan 12, 2017
Signed-off-by:Tetyuev Pavel <jetexe2@gmail.com>
|
condition fixed |
samdark
approved these changes
Jan 12, 2017
SilverFire
requested changes
Jan 14, 2017
| { | ||
| if ($twoWordsConnector === null) { | ||
| $twoWordsConnector = ' ' . Yii::t('yii', 'and') . ' '; |
There was a problem hiding this comment.
I'd rather put spaces inside the translation to allow changing using dictionary.
$twoWordsConnector = Yii::t('yii', ' and ');There was a problem hiding this comment.
Yes, I think it is a very good idea.
|
Merged with adjustment proposed by @SilverFire: 3a1cd7f |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.