Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error handler not escaping error info in debug mode #14492

Merged
merged 5 commits into from Jul 21, 2017

Conversation

@samdark
Copy link
Member

commented Jul 19, 2017

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? -
Fixed issues -

Current code won't actually output any error info. print_r() with true passed as a second argument doesn't print itself but returns a string that we aren't printing afterwards.

Seems it's like that since 2014: 7511de6

@samdark samdark added the type:bug label Jul 19, 2017

@samdark samdark added this to the 2.0.13 milestone Jul 19, 2017

@samdark samdark self-assigned this Jul 19, 2017

@samdark samdark changed the title Fixed DbException not displaying error info Fixed error handler not displaying `yii\db\Exception` error info Jul 19, 2017

@samdark samdark changed the title Fixed error handler not displaying `yii\db\Exception` error info Fixed error handler not displaying yii\db\Exception error info Jul 19, 2017

@samdark samdark force-pushed the fix-db-exception-not-displaying-error-info branch from 728cf9a to feb4067 Jul 19, 2017

@samdark samdark requested review from cebe, SilverFire, dynasource and klimov-paul and removed request for cebe Jul 19, 2017

@cebe

cebe approved these changes Jul 20, 2017

@cebe

This comment has been minimized.

Copy link
Member

commented Jul 20, 2017

Seems it's like that since 2014: 7511de6

that code is fine, seems someone changed it to use php tag later and did not see the second parameter.

@samdark

This comment has been minimized.

Copy link
Member Author

commented Jul 20, 2017

Right. I've pointed out wrong commit. It's the last time it was right...

@cebe

This comment has been minimized.

Copy link
Member

commented Jul 20, 2017

Seems to be a bug in PHP-CS-Fixer :-/ ba0ab40#diff-23a5ef85354dc67ddeec3bb5782a94a2L19

cc @rob006

@cebe
Copy link
Member

left a comment

@samdark same issue exists in framework/views/errorHandler/previousException.php

cebe referenced this pull request Jul 20, 2017

Added php-cs-fixer coding standards validation to Travis CI (#14100)
* php-cs-fixer: PSR2 rule.

* php-cs-fixer: PSR2 rule - fix views.

* Travis setup refactoring.

* Add php-cs-fixer to travis cs tests.

* Fix tests on hhvm-3.12

* improve travis config

* composer update

* revert composer update

* improve travis config

* Fix CS.

* Extract config to separate classes.

* Extract config to separate classes.

* Add file header.

* Force short array syntax.

* binary_operator_spaces fixer

* Fix broken tests

* cast_spaces fixer

* concat_space fixer

* dir_constant fixer

* ereg_to_preg fixer

* function_typehint_space fixer

* hash_to_slash_comment fixer

* is_null fixer

* linebreak_after_opening_tag fixer

* lowercase_cast fixer

* magic_constant_casing fixer

* modernize_types_casting fixer

* native_function_casing fixer

* new_with_braces fixer

* no_alias_functions fixer

* no_blank_lines_after_class_opening fixer

* no_blank_lines_after_phpdoc fixer

* no_empty_comment fixer

* no_empty_phpdoc fixer

* no_empty_statement fixer

* no_extra_consecutive_blank_lines fixer

* no_leading_import_slash fixer

* no_leading_namespace_whitespace fixer

* no_mixed_echo_print fixer

* no_multiline_whitespace_around_double_arrow fixer

* no_multiline_whitespace_before_semicolons fixer

* no_php4_constructor fixer

* no_short_bool_cast fixer

* no_singleline_whitespace_before_semicolons fixer

* no_spaces_around_offset fixer

* no_trailing_comma_in_list_call fixer

* no_trailing_comma_in_singleline_array fixer

* no_unneeded_control_parentheses fixer

* no_unused_imports fixer

* no_useless_return fixer

* no_whitespace_before_comma_in_array fixer

* no_whitespace_in_blank_line fixer

* not_operator_with_successor_space fixer

* object_operator_without_whitespace fixer

* ordered_imports fixer

* php_unit_construct fixer

* php_unit_dedicate_assert fixer

* php_unit_fqcn_annotation fixer

* phpdoc_indent fixer

* phpdoc_no_access fixer

* phpdoc_no_empty_return fixer

* phpdoc_no_package fixer

* phpdoc_no_useless_inheritdoc fixer

* Fix broken tests

* phpdoc_return_self_reference fixer

* phpdoc_single_line_var_spacing fixer

* phpdoc_single_line_var_spacing fixer

* phpdoc_to_comment fixer

* phpdoc_trim fixer

* phpdoc_var_without_name fixer

* psr4 fixer

* self_accessor fixer

* short_scalar_cast fixer

* single_blank_line_before_namespace fixer

* single_quote fixer

* standardize_not_equals fixer

* ternary_operator_spaces fixer

* trailing_comma_in_multiline_array fixer

* trim_array_spaces fixer

* protected_to_private fixer

* unary_operator_spaces fixer

* whitespace_after_comma_in_array fixer

* `parent::setRules()` -> `$this->setRules()`

* blank_line_after_opening_tag fixer

* Update finder config.

* Revert changes for YiiRequirementChecker.

* Fix array formatting.

* Add missing import.

* Fix CS for new code merged from master.

* Fix some indentation issues.

@cebe cebe referenced this pull request Jul 20, 2017

Closed

Problems with PHP-CS-Fixer #14500

5 of 5 tasks complete

samdark added some commits Jul 21, 2017

Fixed additional issue in previous exception, updated changelog to re…
…flect what's actually changed since release version

@samdark samdark changed the title Fixed error handler not displaying yii\db\Exception error info Fixed error handler not escaping error info in debug mode Jul 21, 2017

@samdark

This comment has been minimized.

Copy link
Member Author

commented Jul 21, 2017

Updated.

@samdark samdark merged commit acf29e0 into master Jul 21, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/travis-ci/push The Travis CI build is in progress
Details
codeclimate All good!
Details

@samdark samdark deleted the fix-db-exception-not-displaying-error-info branch Jul 21, 2017

tsingsun pushed a commit to tsingsun/yii2 that referenced this pull request Jan 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.