Fixed #14186, fixed #14510 - forced validation regression (caused by #13105 fix) #14554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I configured GPG key, but forgot to set up signing commits using it for Yii 2 repo. Sorry for that. 😞 Will do for future commits. 😄 |
dynasource
approved these changes
Jul 29, 2017
samdark
approved these changes
Jul 29, 2017
|
Merged. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a regression in forced validation caused by @SilverFire's commit 7d494c1 (which is a fix for #13105). I reverted the changes, these two issues (#14186, #14510) should be fixed now. I'll reopen #13105 for better fix with tests.