hhvm support #1512

cebe · 2013-12-14T00:20:49Z

adjust travis.yml and tests to run on travis
make sure tests run without errors on hhvm

cebe · 2013-12-14T00:48:31Z

Tests are running: https://travis-ci.org/yiisoft/yii2/jobs/15429299

Looks like the main problem is magic __get, __set and __call but the framework code should not rely on this feature. In general it looks like yii2 is useable with hhvm...

qiangxue · 2013-12-14T01:59:47Z

composer.json

 	"minimum-stability": "dev",
-	"replace": {


Why "replace" is removed?

because a regex causes composer to crash otherwise. as stated in the PR message, this is for testing only, not ment to merge, not even later. If there are changes needed we can do them in other branch/commit. This is mainly to test whether there is a sense in supporting hhvm or not. Looks quite okay right now.

cebe · 2013-12-14T02:18:16Z

Open issues:

recursive calls to __get are not working right now in version 2.3.0, will be in 2.4.0 as pointed out in #hhvm irc channel on freenode.

array_multisort() has a problem with call_user_func_array and reference value

4) yiiunit\framework\helpers\ArrayHelperTest::testMultisort

Parameter 1 to array_multisort() expected to be a reference, value given

/home/travis/build/yiisoft/yii2/framework/yii/helpers/BaseArrayHelper.php:393
/home/travis/build/yiisoft/yii2/tests/unit/framework/helpers/ArrayHelperTest.php:114
/home/travis/build/yiisoft/yii2/vendor/phpunit/phpunit/composer/bin/phpunit:63

https://github.com/yiisoft/yii2/blob/master/framework/yii/helpers/BaseArrayHelper.php#L393

Undefined property: PDOException::$errorInfo - should be easy to add a check for that.
issue reported: PDOException does not have errorInfo property facebook/hhvm#1412

DaSourcerer · 2013-12-14T10:09:09Z

Subscribing as I'm eager to know how this will turn out.

cebe · 2013-12-14T17:23:56Z

@DaSourcerer FYI: there is a subscribe button below, so no need for a comment to watch ;-)

DaSourcerer · 2013-12-14T20:14:12Z

But then I couldn't have stated my genuine interest openly 😏

- moved composer to own file - removed coverage from phpunit

just create another file to not fail on hhvm

cebe · 2014-01-04T03:08:56Z

tried once again. We now have the following issues:

recursive __get() calls are the main issue which will be fixed in 2.4.0
OAuth extension uses a parameter that is not implemted in hhvm: http-build-query enc_type parameter and constants missing facebook/hhvm#1485
Undefined property: PDOException::$errorInfo PDOException does not have errorInfo property facebook/hhvm#1412
pass by reference to call_user_func_array Giving parameters to call_user_func_array() by reference does not work. facebook/hhvm#1486
Failure 4 and 5: https://travis-ci.org/yiisoft/yii2/builds/16352558#L1142 - no idea what is going wrong there.
same for 10) https://travis-ci.org/yiisoft/yii2/builds/16352558#L1175
and 11) https://travis-ci.org/yiisoft/yii2/builds/16352558#L1186

SonicGD · 2014-01-13T18:45:19Z

migration tool fails on HHVM because of this line - https://github.com/yiisoft/yii2/blob/master/framework/db/mysql/Schema.php#L190. HHVM returns error code int(1146), not string(42S02).
We can change it to

if ($previous instanceof \PDOException && ($previous->getCode() == '42S02'||$previous->getCode()==1146))

After that it fails with "Database Exception: Redis error: ERR wrong number of arguments for 'set' command" and also need some inspection =)

cebe · 2014-01-13T19:36:58Z

Can you show how to reproduce the issue? Also if behavior between php and hhvm is different you should report that to hhvm.

SonicGD · 2014-01-14T04:39:04Z

@cebe, step by step:

php -v

root@debian:/var/www/yii2/basic# php -v
HipHop VM 2.4.0-dev (rel)
Compiler: heads/master-0-gba8b4bf75a1a2461f3f00a4c048aacdb6835accb
Repo schema: e9c960b671eb36e3bd8085a0ed65937eefe140a9

/etc/hhvm/config.hdf:

MySQL {
  ReadTimeout = 5000
}

EnvVariables {
  HPHP_INTERPRETER = 1
}

ServerVariables {
  ALPHA_CONSOLE = 1
  TFBENV = 16777216
}

ErrorHandling {
  NoticeFrequency = 1
  WarningFrequency = 1
}

Http {
  SlowQueryThreshold = 0
}

ResourceLimit {
  SerializationSizeLimit=134217728
  SocketDefaultTimeout = 20
}

curl -s http://getcomposer.org/installer | php
php composer.phar create-project --prefer-dist --stability=dev yiisoft/yii2-app-basic basic
cd basic && mkdir migrations
edit config/db.php
./yii migrate

root@debian:/var/www/yii2/basic# ./yii migrate
Yii Migration Tool (based on Yii v2.0.0-dev)

HipHop Fatal error: Uncaught exception 'PDOException' with message 'SQLSTATE[42S02] [1146] Table 'cg2_test.tbl_migration' doesn't exist' in :
Stack trace:
#0 /var/www/yii2/basic/vendor/yiisoft/yii2/db/Command.php(397): PDOStatement->execute()
#1 /var/www/yii2/basic/vendor/yiisoft/yii2/db/Command.php(312): yii\db\Command->queryInternal()
#2 /var/www/yii2/basic/vendor/yiisoft/yii2/db/mysql/Schema.php(187): yii\db\Command->queryAll()
#3 /var/www/yii2/basic/vendor/yiisoft/yii2/db/mysql/Schema.php(93): yii\db\mysql\Schema->findColumns()
#4 /var/www/yii2/basic/vendor/yiisoft/yii2/db/Schema.php(110): yii\db\mysql\Schema->loadTableSchema()
#5 /var/www/yii2/basic/vendor/yiisoft/yii2/console/controllers/MigrateController.php(575): yii\db\Schema->getTableSchema()
#6 /var/www/yii2/basic/vendor/yiisoft/yii2/console/controllers/MigrateController.php(614): yii\console\controllers\MigrateController->getMigrationHistory()
#7 /var/www/yii2/basic/vendor/yiisoft/yii2/console/controllers/MigrateController.php(151): yii\console\controllers\MigrateController->getNewMigrations()
#8 (): yii\console\controllers\MigrateController->actionUp()
#9 /var/www/yii2/basic/vendor/yiisoft/yii2/base/InlineAction.php(53): call_user_func_array()
#10 /var/www/yii2/basic/vendor/yiisoft/yii2/base/Controller.php(130): yii\base\InlineAction->runWithParams()
#11 /var/www/yii2/basic/vendor/yiisoft/yii2/console/Controller.php(77): yii\base\Controller->runAction()
#12 /var/www/yii2/basic/vendor/yiisoft/yii2/base/Module.php(586): yii\console\Controller->runAction()
#13 /var/www/yii2/basic/vendor/yiisoft/yii2/console/Application.php(131): yii\base\Module->runAction()
#14 /var/www/yii2/basic/vendor/yiisoft/yii2/console/Application.php(99): yii\console\Application->runAction()
#15 /var/www/yii2/basic/vendor/yiisoft/yii2/base/Application.php(289): yii\console\Application->handleRequest()
#16 /var/www/yii2/basic/yii(22): yii\base\Application->run()
#17 {main}

Next exception 'yii\db\Exception' with message 'SQLSTATE[42S02] [1146] Table 'cg2_test.tbl_migration' doesn't exist
The SQL being executed was: SHOW FULL COLUMNS FROM `tbl_migration`' in /var/www/yii2/basic/vendor/yiisoft/yii2/db/Command.php:424
Stack trace:
#0 /var/www/yii2/basic/vendor/yiisoft/yii2/db/Command.php(312): yii\db\Command->queryInternal()
#1 /var/www/yii2/basic/vendor/yiisoft/yii2/db/mysql/Schema.php(187): yii\db\Command->queryAll()
#2 /var/www/yii2/basic/vendor/yiisoft/yii2/db/mysql/Schema.php(93): yii\db\mysql\Schema->findColumns()
#3 /var/www/yii2/basic/vendor/yiisoft/yii2/db/Schema.php(110): yii\db\mysql\Schema->loadTableSchema()
#4 /var/www/yii2/basic/vendor/yiisoft/yii2/console/controllers/MigrateController.php(575): yii\db\Schema->getTableSchema()
#5 /var/www/yii2/basic/vendor/yiisoft/yii2/console/controllers/MigrateController.php(614): yii\console\controllers\MigrateController->getMigrationHistory()
#6 /var/www/yii2/basic/vendor/yiisoft/yii2/console/controllers/MigrateController.php(151): yii\console\controllers\MigrateController->getNewMigrations()
#7 (): yii\console\controllers\MigrateController->actionUp()
#8 /var/www/yii2/basic/vendor/yiisoft/yii2/base/InlineAction.php(53): call_user_func_array()
#9 /var/www/yii2/basic/vendor/yiisoft/yii2/base/Controller.php(130): yii\base\InlineAction->runWithParams()
#10 /var/www/yii2/basic/vendor/yiisoft/yii2/console/Controller.php(77): yii\base\Controller->runAction()
#11 /var/www/yii2/basic/vendor/yiisoft/yii2/base/Module.php(586): yii\console\Controller->runAction()
#12 /var/www/yii2/basic/vendor/yiisoft/yii2/console/Application.php(131): yii\base\Module->runAction()
#13 /var/www/yii2/basic/vendor/yiisoft/yii2/console/Application.php(99): yii\console\Application->runAction()
#14 /var/www/yii2/basic/vendor/yiisoft/yii2/base/Application.php(289): yii\console\Application->handleRequest()
#15 /var/www/yii2/basic/yii(22): yii\base\Application->run()
#16 {main}
exception 'PDOException' with message 'SQLSTATE[42S02] [1146] Table 'cg2_test.tbl_migration' doesn't exist' in :
Stack trace:
#0 /var/www/yii2/basic/vendor/yiisoft/yii2/db/Command.php(397): PDOStatement->execute()
#1 /var/www/yii2/basic/vendor/yiisoft/yii2/db/Command.php(312): yii\db\Command->queryInternal()
#2 /var/www/yii2/basic/vendor/yiisoft/yii2/db/mysql/Schema.php(187): yii\db\Command->queryAll()
#3 /var/www/yii2/basic/vendor/yiisoft/yii2/db/mysql/Schema.php(93): yii\db\mysql\Schema->findColumns()
#4 /var/www/yii2/basic/vendor/yiisoft/yii2/db/Schema.php(110): yii\db\mysql\Schema->loadTableSchema()
#5 /var/www/yii2/basic/vendor/yiisoft/yii2/console/controllers/MigrateController.php(575): yii\db\Schema->getTableSchema()
#6 /var/www/yii2/basic/vendor/yiisoft/yii2/console/controllers/MigrateController.php(614): yii\console\controllers\MigrateController->getMigrationHistory()
#7 /var/www/yii2/basic/vendor/yiisoft/yii2/console/controllers/MigrateController.php(151): yii\console\controllers\MigrateController->getNewMigrations()
#8 (): yii\console\controllers\MigrateController->actionUp()
#9 /var/www/yii2/basic/vendor/yiisoft/yii2/base/InlineAction.php(53): call_user_func_array()
#10 /var/www/yii2/basic/vendor/yiisoft/yii2/base/Controller.php(130): yii\base\InlineAction->runWithParams()
#11 /var/www/yii2/basic/vendor/yiisoft/yii2/console/Controller.php(77): yii\base\Controller->runAction()
#12 /var/www/yii2/basic/vendor/yiisoft/yii2/base/Module.php(586): yii\console\Controller->runAction()
#13 /var/www/yii2/basic/vendor/yiisoft/yii2/console/Application.php(131): yii\base\Module->runAction()
#14 /var/www/yii2/basic/vendor/yiisoft/yii2/console/Application.php(99): yii\console\Application->runAction()
#15 /var/www/yii2/basic/vendor/yiisoft/yii2/base/Application.php(289): yii\console\Application->handleRequest()
#16 /var/www/yii2/basic/yii(22): yii\base\Application->run()
#17 {main}

Next exception 'yii\db\Exception' with message 'SQLSTATE[42S02] [1146] Table 'cg2_test.tbl_migration' doesn't exist
The SQL being executed was: SHOW FULL COLUMNS FROM `tbl_migration`' in /var/www/yii2/basic/vendor/yiisoft/yii2/db/Command.php:424
Stack trace:
#0 /var/www/yii2/basic/vendor/yiisoft/yii2/db/Command.php(312): yii\db\Command->queryInternal()
#1 /var/www/yii2/basic/vendor/yiisoft/yii2/db/mysql/Schema.php(187): yii\db\Command->queryAll()
#2 /var/www/yii2/basic/vendor/yiisoft/yii2/db/mysql/Schema.php(93): yii\db\mysql\Schema->findColumns()
#3 /var/www/yii2/basic/vendor/yiisoft/yii2/db/Schema.php(110): yii\db\mysql\Schema->loadTableSchema()
#4 /var/www/yii2/basic/vendor/yiisoft/yii2/console/controllers/MigrateController.php(575): yii\db\Schema->getTableSchema()
#5 /var/www/yii2/basic/vendor/yiisoft/yii2/console/controllers/MigrateController.php(614): yii\console\controllers\MigrateController->getMigrationHistory()
#6 /var/www/yii2/basic/vendor/yiisoft/yii2/console/controllers/MigrateController.php(151): yii\console\controllers\MigrateController->getNewMigrations()
#7 (): yii\console\controllers\MigrateController->actionUp()
#8 /var/www/yii2/basic/vendor/yiisoft/yii2/base/InlineAction.php(53): call_user_func_array()
#9 /var/www/yii2/basic/vendor/yiisoft/yii2/base/Controller.php(130): yii\base\InlineAction->runWithParams()
#10 /var/www/yii2/basic/vendor/yiisoft/yii2/console/Controller.php(77): yii\base\Controller->runAction()
#11 /var/www/yii2/basic/vendor/yiisoft/yii2/base/Module.php(586): yii\console\Controller->runAction()
#12 /var/www/yii2/basic/vendor/yiisoft/yii2/console/Application.php(131): yii\base\Module->runAction()
#13 /var/www/yii2/basic/vendor/yiisoft/yii2/console/Application.php(99): yii\console\Application->runAction()
#14 /var/www/yii2/basic/vendor/yiisoft/yii2/base/Application.php(289): yii\console\Application->handleRequest()
#15 /var/www/yii2/basic/yii(22): yii\base\Application->run()
#16 {main}

SonicGD · 2014-01-14T04:50:19Z

To see difference this script can be used:

try {
    $db = new PDO("mysql:host=localhost;dbname=db", 'login', 'password');
    $db->setAttribute(PDO::ATTR_ERRMODE, PDO::ERRMODE_EXCEPTION);
    $res = $db->query('SHOW FULL COLUMNS FROM `tbl_migration`');
} catch (PDOException $e) {
    var_dump($e->getCode());
}

Try on php:

root@debian:/var/www/cg2# php -v
PHP 5.5.7-2 (cli) (built: Dec 12 2013 23:06:38) 
Copyright (c) 1997-2013 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2013 Zend Technologies
    with Zend OPcache v7.0.3-dev, Copyright (c) 1999-2013, by Zend Technologies
root@debian:/var/www/cg2# php hhvm-pdo.php 
string(5) "42S02"

Try on hhvm:

root@debian:/var/www/cg2# php -v
HipHop VM 2.4.0-dev (rel)
Compiler: heads/master-0-gba8b4bf75a1a2461f3f00a4c048aacdb6835accb
Repo schema: e9c960b671eb36e3bd8085a0ed65937eefe140a9
root@debian:/var/www/cg2# php hhvm-pdo.php
int(1146)

SonicGD · 2014-01-14T04:54:49Z

I found this in hhvm tracker - facebook/hhvm#1498 (comment)

SonicGD · 2014-01-14T05:31:25Z

Also, redis cache fails when expiration time != 0

require(__DIR__ . '/vendor/autoload.php');
require(__DIR__ . '/vendor/yiisoft/yii2/Yii.php');

$config = yii\helpers\ArrayHelper::merge(
    require(__DIR__ . '/console/config/main.php'),
    require(__DIR__ . '/console/config/main-test.php')
);

$application = new yii\console\Application($config);
\Yii::$app->cache->set("hhvmtest", "123");
try {
    \Yii::$app->cache->set("hhvmtest2", "456", 1);
} catch (\yii\base\Exception $ex) {
    echo $ex->getMessage() . "\n";
}
var_dump(\Yii::$app->cache->get('hhvmtest'));
var_dump(\Yii::$app->cache->get('hhvmtest2'));

PHP:

root@debian:/var/www/cg2# php -v
PHP 5.5.7-2 (cli) (built: Dec 12 2013 23:06:38) 
Copyright (c) 1997-2013 The PHP Group
Zend Engine v2.5.0, Copyright (c) 1998-2013 Zend Technologies
    with Zend OPcache v7.0.3-dev, Copyright (c) 1999-2013, by Zend Technologies
root@debian:/var/www/cg2# php hhvm-redis.php 
string(3) "123"
string(3) "456"

HHVM:

root@debian:/var/www/cg2# php -v
HipHop VM 2.4.0-dev (rel)
Compiler: heads/master-0-gba8b4bf75a1a2461f3f00a4c048aacdb6835accb
Repo schema: e9c960b671eb36e3bd8085a0ed65937eefe140a9
root@debian:/var/www/cg2# php hhvm-redis.php
Redis error: ERR wrong number of arguments for 'set' command
Redis command was: SET hhvmtest2 a:2:{i:0;s:3:"456";i:1;N;} PX 1000
string(3) "123"
bool(false)

SonicGD · 2014-01-14T06:18:07Z

Hm, redis problem solved by upgrading redis-server from 2.4.14 (wheezy stable) to 2.8.3 (dotdeb).

Added: redis/redis-rb#372 (comment)
So yii2-redis require redis-server>=2.6.12. Maybe it should be mentioned somewhere.

* master: (870 commits) added `yiisoft/yii2-coding-standards` to yii2-dev suggested packages Removed unused variables Removed unused namespace imports Removed unused assignment support panel hiding. further improved custom panel setting. CS fix. tests improved code fix Added support to disable a debug panel. tests improved docs added updated elasticsearch querybuilder test to use yiitest index Fix typo Fixes yiisoft#2346: ActiveQuery used in building sub-query should not need to set FROM clause explicitly. Update FixtureController.php reverting Fixes yiisoft#2310 The scripts in asset bundles are now registered in `View` at the end of `endBody()`. It was done in `endPage()` previously doc improvement [skip ci] ... Conflicts: .travis.yml

cebe · 2014-03-03T19:45:17Z

closing this as builds are now running and status is tracked in #1511

qiangxue reviewed Dec 14, 2013
View reviewed changes

cebe added 2 commits January 4, 2014 03:28

make tests run on hhvm on travis

1662c85

- moved composer to own file - removed coverage from phpunit

fixed test break with same php file and diff content

19fe044

just create another file to not fail on hhvm

triggering a new travis build

06eea23

cebe closed this Mar 3, 2014

cebe deleted the hhvm-support branch March 3, 2014 19:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

hhvm support #1512

hhvm support #1512

cebe commented Dec 14, 2013

cebe commented Dec 14, 2013

qiangxue Dec 14, 2013

cebe Dec 14, 2013

cebe commented Dec 14, 2013

DaSourcerer commented Dec 14, 2013

cebe commented Dec 14, 2013

DaSourcerer commented Dec 14, 2013

cebe commented Jan 4, 2014

SonicGD commented Jan 13, 2014

cebe commented Jan 13, 2014

SonicGD commented Jan 14, 2014

SonicGD commented Jan 14, 2014

SonicGD commented Jan 14, 2014

SonicGD commented Jan 14, 2014

SonicGD commented Jan 14, 2014

cebe commented Mar 3, 2014

hhvm support #1512

hhvm support #1512

Conversation

cebe commented Dec 14, 2013

cebe commented Dec 14, 2013

qiangxue Dec 14, 2013

Choose a reason for hiding this comment

cebe Dec 14, 2013

Choose a reason for hiding this comment

cebe commented Dec 14, 2013

DaSourcerer commented Dec 14, 2013

cebe commented Dec 14, 2013

DaSourcerer commented Dec 14, 2013

cebe commented Jan 4, 2014

SonicGD commented Jan 13, 2014

cebe commented Jan 13, 2014

SonicGD commented Jan 14, 2014

SonicGD commented Jan 14, 2014

SonicGD commented Jan 14, 2014

SonicGD commented Jan 14, 2014

SonicGD commented Jan 14, 2014

cebe commented Mar 3, 2014