-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rbac default role closure support #15422
Rbac default role closure support #15422
Conversation
deltacube
commented
Dec 28, 2017
•
edited by samdark
Loading
edited by samdark
Q | A |
---|---|
Is bugfix? | no |
New feature? | yes |
Breaks BC? | no |
Tests pass? | yes |
Fixed issues |
Thank you for putting effort in the improvement of the Yii framework. In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests. Could you add these please? Thanks! P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests This is an automated comment, triggered by adding the label |
framework/CHANGELOG.md
Outdated
@@ -56,6 +56,7 @@ Yii Framework 2 Change Log | |||
- Enh #15357: Added multi statement support for `yii\db\sqlite\Command` (sergeymakinen) | |||
- Enh #15360: Refactored `BaseConsole::updateProgress()` (developeruz) | |||
- Enh #15415: Added transaction/retry support for `yii\db\Command` (sergeymakinen) | |||
- Enh #15416: Added default roles dynamic definition support via closure for `yii\rbac\BaseManager` (deltacube) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- The number you've used is not related.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, sorry. Just fixed
Merged. Thank you! |