Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

method not allowed exception message translation zh-CN #16038

Closed
wants to merge 2 commits into from
Closed

method not allowed exception message translation zh-CN #16038

wants to merge 2 commits into from

Conversation

oraluben
Copy link
Contributor

@oraluben oraluben commented Apr 4, 2018

Q A
Is bugfix? no
New feature? no
Breaks BC? no
Tests pass? yes
Fixed issues None

Translate for zh-CN

@cebe
Copy link
Member

cebe commented Apr 4, 2018 •
edited

Thanks for the contribution, however we have the convention to not translate exception messages:

  1. When to translate messages messages should be translated when these are displayed to non-tech end user and make sense to him. HTTP status messages, exceptions about the code etc. should not be translated. Console messages are always in English because of encoding and codepage handling difficulties.
    https://github.com/yiisoft/yii2/blob/master/docs/internals/design-decisions.md

@samdark samdark closed this Apr 4, 2018
@oraluben
Copy link
Contributor Author

oraluben commented Apr 5, 2018 •
edited by cebe

sorry for not seeing this. previously i was looking at #8931 (comment) and it seems that i have some misunderstandings. i will delete the exception commit and keep the other translation.

@samdark samdark reopened this Apr 5, 2018
@samdark samdark added the type:docs Documentation label Apr 5, 2018
@samdark samdark self-assigned this Apr 5, 2018
@samdark samdark closed this Apr 5, 2018
@oraluben oraluben deleted the 'method-not-allowed-exception-message-translation-zh-CN' branch April 6, 2018 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@samdark samdark

Labels
type:docs Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oraluben @cebe @samdark