FileCache: rebuild cache file before touch when different file owner #16120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Slamdunk
commented
Apr 18, 2018
•
Slamdunk
commented
| Q | A |
|---|---|
| Is bugfix? | yes |
| New feature? | no |
| Breaks BC? | no |
| Tests pass? | yes |
| Fixed issues | #16050 |
- Prove the bug: https://travis-ci.org/yiisoft/yii2/builds/368030555
- Implement fix
Slamdunk
changed the title
samdark
reviewed
Apr 18, 2018
framework/caching/FileCache.php
Outdated
| // If ownership differs the touch call will fail, so we try to | ||
| // rebuild the file from scratch by deleting it first | ||
| // https://github.com/yiisoft/yii2/pull/16120 | ||
| if (is_file($cacheFile) && fileowner($cacheFile) !== posix_geteuid()) { |
There was a problem hiding this comment.
posix_geteuid() may not be available. For example, it's not available under Windows.
There was a problem hiding this comment.
If so this library needs an AppVeyor build.
It would be easy to add a function_exists('posix_geteuid') here, but I don't like making changes that aren't tested.
There was a problem hiding this comment.
Merged AppVeyor. It fails in some tests: https://ci.appveyor.com/project/samdark/yii2/build/dev-1
There was a problem hiding this comment.
I think you need to merge with master in order for build to be triggered...
There was a problem hiding this comment.
https://ci.appveyor.com/project/samdark/yii2/build/dev-6#L274
Now that I have a failing test, I'll fix the code
Merged
Slamdunk
force-pushed
the
fix_16050_different_cache_users
branch
from
7f4a171
to
b8f4b71
Compare
samdark
approved these changes
Apr 19, 2018
Slamdunk
force-pushed
the
fix_16050_different_cache_users
branch
from
2eefef2
to
5597f02
Compare
SilverFire
approved these changes
Apr 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.