Fix namespace issue #16602
Merged
Fix namespace issue #16602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Causes an error when `YII_DEBUG` is `true`, `$cors['Origin']` contains `'*'` and `$cors['Access-Control-Allow-Credentials']` is `true`
|
Merged. Thanks! |
rob006
reviewed
Aug 4, 2018
| @@ -167,7 +167,7 @@ public function prepareHeaders($requestHeaders) | |||
| // Per CORS standard (https://fetch.spec.whatwg.org), wildcard origins shouldn't be used together with credentials | |||
| if (isset($this->cors['Access-Control-Allow-Credentials']) && $this->cors['Access-Control-Allow-Credentials']) { | |||
| if (YII_DEBUG) { | |||
| throw new Exception("Allowing credentials for wildcard origins is insecure. Please specify more restrictive origins or set 'credentials' to false in your CORS configuration."); | |||
| throw new \Exception("Allowing credentials for wildcard origins is insecure. Please specify more restrictive origins or set 'credentials' to false in your CORS configuration."); | |||
There was a problem hiding this comment.
It does not look right - \Exception is too generic. It should be InvalidConfigException or at least yii\base\Exception.
|
This was already fixed in master: #16292 Why this change is target to 2.0.16 but merged to 3.0? Both versions should use the same fix with |
|
Oh, thought it's against master... 3.0 branch doesn't make much sense now as we're doing it other way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Causes an error when
YII_DEBUGistrue,$cors['Origin']contains'*'and$cors['Access-Control-Allow-Credentials']istrue