Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 16639 postgres load indexes #16644

Closed
wants to merge 3 commits into from
Closed

Issue 16639 postgres load indexes #16644

wants to merge 3 commits into from

Conversation

carono
Copy link
Contributor

@carono carono commented Aug 17, 2018

Q A
Is bugfix? yes
New feature? no
Breaks BC? no
Tests pass? no
Fixed issues #16639

columnNames are formed taking into account the actual position in the database

#16639
@yii-bot
Copy link

yii-bot commented Aug 19, 2018

Thank you for putting effort in the improvement of the Yii framework.
We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

@samdark
Copy link
Member

samdark commented Aug 20, 2018

Are you sure that sub-query won't affect schema reading performance significantly?

@carono
Copy link
Contributor Author

carono commented Aug 20, 2018

I will answer this question a little later, I will make measurements of productivity. I'll also try to make a single request

@carono
Copy link
Contributor Author

carono commented Aug 22, 2018

you're right, there's still something to think about optimizing the subquery.

tables: 100
columns in each table: 20
indexes in each table: 15
index length: 2 - 10 columns
queries: 10000

Current query: 17sec
With sub query: 49sec

I will have to remove the subquery, but I do not yet know how =)

@samdark
Copy link
Member

samdark commented Sep 17, 2019

Closing since in its current form the pull request affects performance significantly.

@samdark samdark closed this Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants