Fixed bug where component behaviors could be double-attached #16663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a 3.0 bug introduced in yiisoft#16430. If a component's behaviors() method returns any behaviors without a name, then cloning it would result in the behavior getting attached twice.
|
The change most probably will be lost since we've switched to https://github.com/yiisoft/yii-core etc. |
|
@samdark Ah I had missed the new repos. Just submitted yiisoft/yii-core#17 with the same fix. |
|
@samdark Wait, we're not going to merge changes from |
|
Nope. It's unreal. |
|
It is more real than moving every change manually. Especially if you want to do this nicely, with keeping history and authorship. |
|
There are many changes made to the code itself so commits are mostly not merge-able. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a 3.0 bug introduced in #16430.
If a component's behaviors() method returns any behaviors without a name, then cloning it would result in the behavior getting attached twice.