Add ability to turn the sorting off for a clicked column in GridView with multisort #18826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ditibal
commented
Aug 11, 2021
•
ditibal
commented
| Q | A |
|---|---|
| Is bugfix? | ❌ |
| New feature? | ✔️ |
| Breaks BC? | ❌ |
| Tests pass? | ✔️ |
| Fixed issues | #18599 |
bizley
reviewed
Aug 11, 2021
framework/data/Sort.php
Outdated
| @@ -438,14 +438,25 @@ public function createSortParam($attribute) | |||
| $definition = $this->attributes[$attribute]; | |||
| $directions = $this->getAttributeOrders(); | |||
| if (isset($directions[$attribute])) { | |||
| $direction = $directions[$attribute] === SORT_DESC ? SORT_ASC : SORT_DESC; | |||
| if ($this->enableMultiSort && count($directions) > 1) { | |||
There was a problem hiding this comment.
I think it would be nice to have this feature when enableMultiSort is on even for one sortable column.
|
Tests need fixing. Also please add changelog line 👍🏻 |
@bizley done |
bizley
approved these changes
Aug 11, 2021
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.