Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug with binding default action parameters for controllers #18940

Merged
merged 2 commits into from
Oct 18, 2021
Merged

Fix bug with binding default action parameters for controllers #18940

merged 2 commits into from
Oct 18, 2021

Conversation

bizley
Copy link
Member

@bizley bizley commented Oct 8, 2021

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Tests pass? ✔️
Fixed issues #18909

@bizley bizley added the type:bug Bug label Oct 8, 2021
@bizley bizley added this to the 2.0.44 milestone Oct 8, 2021
@bizley bizley requested a review from a team October 8, 2021 07:57
@WinterSilence
Copy link
Contributor

why not move it up (yii\base\Controller)?

@bizley
Copy link
Member Author

bizley commented Oct 8, 2021

Different implementations for web and console.

@WinterSilence
Copy link
Contributor

@bizley diff display minimal differences

@samdark samdark merged commit ae82b58 into yiisoft:master Oct 18, 2021
@samdark
Copy link
Member

samdark commented Oct 18, 2021

👍

@bizley bizley deleted the 18909-params-binding branch October 19, 2021 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
type:bug Bug
Projects
None yet
Milestone
2.0.44
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bizley @WinterSilence @samdark