Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Model::attributes() #19309

Merged
merged 2 commits into from
Mar 18, 2022
Merged

Rewrite Model::attributes() #19309

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c13f346
Optimize Model::attributes()
WinterSilence Mar 16, 2022
32f79bc
Update CHANGELOG.md
WinterSilence Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions framework/base/Model.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,21 +260,15 @@ public function formName()

/**
* Returns the list of attribute names.
*
* By default, this method returns all public non-static properties of the class.
* You may override this method to change the default behavior.
* @return array list of attribute names.
*
* @return string[] list of attribute names.
*/
public function attributes()
{
$class = new ReflectionClass($this);
$names = [];
foreach ($class->getProperties(\ReflectionProperty::IS_PUBLIC) as $property) {
if (!$property->isStatic()) {
$names[] = $property->getName();
}
}

return $names;
return array_keys(Yii::getObjectVars($this));
}

/**
Expand Down