Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize methods in ArrayableTrait #19434

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

WinterSilence
Copy link
Contributor

@WinterSilence WinterSilence commented Jun 12, 2022

Optimize fields(), extractRootFields() and extractFieldsFor()

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues

- Optimize `fields()`, `extractRootFields()` and `extractFieldsFor()`
- Fix passing `$recursive`  to inner Arrayable objects in  `toArray()`
- Fix case-sensitive search in `extractFieldsFor()`
@WinterSilence WinterSilence marked this pull request as ready for review June 12, 2022 18:49
@samdark samdark added the pr:request for unit tests Unit tests are needed. label Jun 17, 2022
@yii-bot
Copy link

yii-bot commented Jun 17, 2022

Thank you for putting effort in the improvement of the Yii framework.
We have reviewed your pull request.

In order for the framework and your solution to remain stable in the future, we have a unit test requirement in place. Therefore we can only accept your pull request if it is covered by unit tests.

Could you add these please?

Thanks!

P.S. If you have any questions about the creation of unit tests? Don't hesitate to ask for support. More information about unit tests

This is an automated comment, triggered by adding the label pr:request for unit tests.

@WinterSilence
Copy link
Contributor Author

@samdark no need extra tests

@samdark samdark removed the pr:request for unit tests Unit tests are needed. label Jun 20, 2022
@samdark
Copy link
Member

samdark commented Jun 20, 2022

I think for "Fix passing $recursive to inner Arrayable objects in toArray()" tests are needed since there's a fix.

@WinterSilence
Copy link
Contributor Author

@samdark I'm rollback this changes after local tests - it's create infinity loop in some cases

@WinterSilence WinterSilence changed the title Optimize and fix ArrayableTrait Optimize methods in ArrayableTrait Jul 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants