MongoDB Session class #1944
Merged
MongoDB Session class #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (YII_DEBUG) { | ||
| echo $e->getMessage(); | ||
| } | ||
| // it is too late to log an error message here |
There was a problem hiding this comment.
Why can't we log a message here? Also stacktrace should be printed additionally to the message.
Maybe a workaround like this is applicable here: https://github.com/yiisoft/yii2/blob/master/framework/mail/BaseMessage.php#L43 ?
There was a problem hiding this comment.
I don't know. This is the part of DbSession code adapted for MongoDB.
There was a problem hiding this comment.
will add a separate issue for this then. #1946 to be fixed in general, so you can merge this PR without change.
|
rest looks good to me :) |
| $query = new Query; | ||
| $row = $query->from($this->sessionCollection) | ||
| ->where(['id' => $oldID]) | ||
| ->one($this->db); |
There was a problem hiding this comment.
I think that there is better to use count()
There was a problem hiding this comment.
row is used in code afterwards. count is not sufficient.
ghost
assigned
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add mongo db session storage.
Migrated from #1920