Change property visibility to allow more flexibility for apps #19696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit #18975 throws warning when reusing the
View
object more than once in a single request. This unfortunately ignores possible legit use cases. For example in one our app we have CMS admin, which requires in first step fetching & parsing View output from the page being edited (find placeholders) and then in returned view (2. View usage) display editable areas. Since 2.0.44 our logger is bloated with warningsYou\'re trying to register a file after View::endBody() has been called
. Since the property has been assignedprivate
, there is no way to allow overriding behavior in an application e.g. for specific controllers only.This commit alleviates aforementioned issue by changing property visibility from
private
toprotected
.