Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added pcntl to requirements check #19780

Merged
merged 3 commits into from
Sep 22, 2023

Conversation

schmunk42
Copy link
Contributor

Q A
Is bugfix?
New feature?
Breaks BC?
Fixed issues #19779

@what-the-diff
Copy link

what-the-diff bot commented Feb 27, 2023

  • Added a new requirement for the pcntl extension.

Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Need a line for CHANGELOG.

@terabytesoftw
Copy link
Member

Hi, @schmunk42, could update the branch and add the line in CHANGELOG.md to merge it,

Thks.

@codecov
Copy link

codecov bot commented Sep 21, 2023

Codecov Report

Patch coverage has no change and project coverage change: -37.07% ⚠️

Comparison is base (81f3033) 48.95% compared to head (eb2add3) 11.88%.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #19780       +/-   ##
===========================================
- Coverage   48.95%   11.88%   -37.07%     
===========================================
  Files         445      445               
  Lines       42811    42269      -542     
===========================================
- Hits        20957     5025    -15932     
- Misses      21854    37244    +15390     
Files Changed Coverage Δ
framework/requirements/requirements.php 0.00% <0.00%> (ø)

... and 290 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@schmunk42
Copy link
Contributor Author

Hi, @schmunk42, could update the branch and add the line in CHANGELOG.md to merge it,

Thks.

done

@bizley bizley merged commit 33fde4b into yiisoft:master Sep 22, 2023
48 of 50 checks passed
@bizley
Copy link
Member

bizley commented Sep 22, 2023

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants