Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecated: mb_strlen(): Passing null to parameter #1 ($string) of type string is deprecated #19833

Merged
merged 3 commits into from
May 12, 2023
Merged

Deprecated: mb_strlen(): Passing null to parameter #1 ($string) of type string is deprecated #19833

merged 3 commits into from
May 12, 2023

Conversation

uaoleg
Copy link
Contributor

@uaoleg uaoleg commented May 11, 2023

Q A
Is bugfix? ✔️
New feature? ❌
Breaks BC? ❌
Fixed issues #19736

@uaoleg uaoleg mentioned this pull request May 11, 2023
Closed
@what-the-diff
Copy link

what-the-diff bot commented May 11, 2023

PR Summary

  • Improved type casting in byteSubstr() function
    Modified the function to ensure the first parameter is treated as a string.

  • Optimization of basename() function
    Updated the function to cast the first parameter as a string and eliminated an unnecessary variable assignment, making the code more efficient.

@samdark samdark added this to the 2.0.48 milestone May 11, 2023
@samdark samdark changed the base branch from master to php82 May 11, 2023 19:13
@samdark samdark changed the base branch from php82 to master May 11, 2023 19:14
samdark
samdark reviewed May 11, 2023
View reviewed changes
Copy link
Member

@samdark samdark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good. Please add a line for CHANGELOG.

@uaoleg
Copy link
Contributor Author

uaoleg commented May 12, 2023

@samdark done

@uaoleg
Copy link
Contributor Author

uaoleg commented May 12, 2023 •
edited
Loading

@samdark looks like this issue was the last related to PHP 8.1 bugs. Can we cut off the rest of 2.0.48 issues to make a release?

@samdark
Copy link
Member

samdark commented May 12, 2023

@uaoleg I'd like to have 8.2 in.

@samdark samdark merged commit 821f72d into yiisoft:master May 12, 2023
23 of 26 checks passed
@samdark
Copy link
Member

samdark commented May 12, 2023

Thanks!

@uaoleg uaoleg deleted the patch-3 branch June 4, 2023 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samdark samdark samdark approved these changes

@xepozz xepozz xepozz approved these changes

@Arhell Arhell Arhell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.48
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@uaoleg @samdark @xepozz @Arhell