Remove unnecessary type #19932
Merged
Remove unnecessary type #19932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because Web and Console application extend Base application there is no need to specify it. Actually, PHPStan narrows this to _just_ BaseApplication because it is the only consistent type of the three so you lose Web and Console Application type hints. See, https://phpstan.org/r/d21fb99f-c436-480b-99c2-32df35ec07fa
PR Summary
|
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #19932 +/- ##
=======================================
Coverage 48.90% 48.90%
=======================================
Files 445 445
Lines 42806 42806
=======================================
Hits 20935 20935
Misses 21871 21871
☔ View full report in Codecov by Sentry. |
samdark
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because Web and Console application extend Base application there is no need to specify it.
Actually, PHPStan narrows this to just BaseApplication because it is the only consistent type of the three so you lose Web and Console Application type hints.
See, https://phpstan.org/r/d21fb99f-c436-480b-99c2-32df35ec07fa
Yii::$appstatic property