Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #19978 - Mistake in Korean translation #19982

Merged

Conversation

xicond
Copy link
Contributor

@xicond xicond commented Sep 26, 2023

fix: #19978 - Mistake in Korean translation

Q A
Is bugfix? ✔️
New feature?
Breaks BC?
Fixed issues #19978

@what-the-diff
Copy link

what-the-diff bot commented Sep 26, 2023

PR Summary

  • Update of validation error messages in Korean translations
    This update improves the translations for certain validation error messages in the Korean language file ('yii.php'). The updated messages provide clearer context to users by using specific attribute bounds rather than a generic term.

    • Updated the 'maximum limit error' message to use the upper bound value provided in the "{max}" variable instead of the generic "{compareValue}" variable.
    • Similarly, updated the 'minimum limit error' message to use the lower bound value in the "{min}" variable instead of the "{compareValue}" variable.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (7576761) 48.94% compared to head (17386c7) 48.94%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #19982   +/-   ##
=======================================
  Coverage   48.94%   48.94%           
=======================================
  Files         445      445           
  Lines       42818    42818           
=======================================
  Hits        20957    20957           
  Misses      21861    21861           
Files Coverage Δ
framework/messages/ko/yii.php 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizley bizley added the type:docs Documentation label Sep 26, 2023
@bizley bizley merged commit 98c4bb8 into yiisoft:master Sep 26, 2023
49 of 50 checks passed
@bizley bizley added this to the 2.0.50 milestone Sep 26, 2023
@bizley
Copy link
Member

bizley commented Sep 26, 2023

Thank you.

@xicond
Copy link
Contributor Author

xicond commented Sep 27, 2023

@bizley
will this bring to 2.2 branch ?

@bizley
Copy link
Member

bizley commented Sep 27, 2023

We will merge it there eventually, yes.

@xicond xicond deleted the bugfix/19978-Mistake_in_Korean_translation branch September 28, 2023 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:docs Documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mistake in Korean translation.
2 participants