added support to parse json request to Request::getRestParams() #2065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebe
referenced
this pull request
Jan 19, 2014
…web\Request::acceptedContentTypes` to `acceptableContentTypes`. Renamed `yii\web\Request::acceptedLanguages` to `acceptableLanguages`
qiangxue
added a commit
that referenced
this pull request
Jan 19, 2014
added support to parse json request to Request::getRestParams()
|
Looks great to me! |
| @@ -256,6 +257,8 @@ public function getRestParams() | |||
| if ($this->_restParams === null) { | |||
| if (isset($_POST[$this->restVar])) { | |||
| $this->_restParams = $_POST; | |||
| } elseif(strncmp($this->getContentType(), 'application/json', 16) === 0) { | |||
| $this->_restParams = Json::decode($this->getRawBody(), true); | |||
There was a problem hiding this comment.
What if would be "text/json"?
There was a problem hiding this comment.
There was a problem hiding this comment.
Of course, application/json is canonical and perhaps the only one correct.
However, you will wonder how many applications which use different mime type for it exist.
I assume we can just check if mime type is ending on /json instead of full comparison.
There was a problem hiding this comment.
Yii 1 got a nice method in 1.1.14 to parse mime types. You could just compare the sub type and ignore type (the first part).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
8805943#commitcomment-5112508