Fixes #225: PHAR package support (second try) #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public static function realpath($path, $checkPhar = false) | ||
| { | ||
| if ($checkPhar && \Phar::running() === '') { |
There was a problem hiding this comment.
if (!$checkPhar || \Phar::running() === '') {
| array_splice($path, $key - ($keyPosition * 2 + 1), 2); | ||
| } | ||
| $path = $scheme . str_replace('./', '', implode('/', $path)); | ||
| return is_file($path) || is_dir($path) ? $path : false; |
There was a problem hiding this comment.
$path should use DIRECTORY_SEPARATOR rather than /. Otherwise you are changing the behavior of realpath() and will cause unexpected problems.
|
Closed for now. We may revisit this after GA. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#246 has been enhanced and improved.
Fixes #225.
Ready to be merged.