GridView filter error indication added (#3154) #3164
Conversation
| { | ||
| $filterClass .= ' '; | ||
| } | ||
| $this->filterOptions['class'] = $filterClass . 'has-error'; |
There was a problem hiding this comment.
It is better to use Html::addCssClass instead
|
Updated the code, still interested in suggestions and comments. Thank you for your time. |
|
are you sure that |
|
Agree, this functionality is GridView specific so we do not need any code for it in BaseListView. |
|
you should overwrite |
| * - `{sorter}`: the sorter. See [[renderSorter()]]. | ||
| * - `{pager}`: the pager. See [[renderPager()]]. | ||
| */ | ||
| public $layout = "{summary}\n{errors}\n{items}\n{pager}"; |
There was a problem hiding this comment.
I'm not certain about that - should I place it here? It makes hard to overwrite the default by simply changing the BaseListView::$layout then.
There was a problem hiding this comment.
It is okay if gridview has its own layout as its appearance is different anyway.
…or-indication GridView filter error indication added (#3154)
|
Thanks! |
According to #3154.