Check if property is set

[alex-code]

getValue didn't check if the property on an object exists so wouldn't return the default value.

[samdark]

Merged. Thank you.

[cebe]

okay, but if we want the null value instead of the default value? This behavior is now different from array.

[samdark]

@cebe we have 3 variants:

1. Change it to property_exists. That will match behavior to array one but has issues: it's slow and may not work with magic properties.
2. Leave as it's now. Nulls will be replaced with default value.
3. Remove check. It will trigger error instead of using default value.

[qiangxue]

IMO, 1 is out of question. 2 and 3 both have points, but I prefer 3 for the following reasons:

• trying to get an undefined property of an object is a programming error. It's better to trigger the error than returning a default value.
• it's a bit faster than 2 because the isset() check will cause evaluation of the property.

[cebe]

I'd vote for reverting the change too.

[samdark]

Reverted 44273f0

[alex-code]

That' a shame, It was useful for relations.
ArrayHelper::getValue($model, 'relation1.relation2.value'), $default)

Maybe a note should be added to the docs to say if it's an object $default doesn't apply.