Fixed limit applying for Oracle queries. #4254
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
MSSQL has similar problem and cannot be solved using this approach. Perhaps we should fix |
|
This request solve this problem for Oracle. |
|
May by combine QueryBuilder::buildLimit() and QueryBuilder::buildOrder(), this wil help to solve this problem. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most DB limit applying on query done through concatenating query with limit string, like
LIMIT n OFFSET m. Such case in Oracle done through wrapping whole query by special query. In all schemes, except\yii\db\oci,QueryBuilder::buildLimit()returns limit string for concatenating.\yii\db\oci\QueryBuilder::buildLimit()returns whole query with applied limit.At first this brakes method behaviour. Also such behaviour does not work in
SqlDataProvider.