-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance Inflector helper with ascii function #464
Merged
Merged
Changes from 13 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
ea8b6e7
enhance Inflector helper with ascii function
10c52d7
updated transliteration (greek + russian + german + ukrainian) and re…
6546168
Merge branch 'upstream' into 364-toAscii
e4e1871
fix functionality, keep each function to do what it supposed to do
9ff2580
fix test
0aab6de
Merge remote-tracking branch 'upstream/master' into 364-toAscii
6b3abee
Merge branch 'upstream' into 364-toAscii
tonydspaniard fc9fb80
added TransliteratorHelper class
tonydspaniard 26330b9
removed ascii method and use the new TransliteratorHelper::process at…
tonydspaniard b7904c4
remove TransliteratorHelper
tonydspaniard 08aaeda
refactored inflector's slug and improved fallback char map
tonydspaniard 6f932d9
Merge branch 'upstream' into 364-toAscii
tonydspaniard 61591ea
update phpDoc
tonydspaniard b918fa5
Merge branch 'upstream' into 364-toAscii
tonydspaniard 8c1715d
remove UTF-8 string conversion
tonydspaniard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed? Or is it correct to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to be very defensive always on code. Maybe it is not needed. I can remove it.