#6131

[aleksanderd]

Closes #6131

[samdark]

#6131

[qiangxue]

Would you help add some unit tests? InflectorTest::testCamel2id()?

[RusAlex]

Do you have any naming convetion ? maybe $result could be better here.
$return is not good imho

[samdark]

Yes, $result is better.

[cebe]

Isn't this change breaking BC? What am I missing?

[samdark]

I think it is.

[qiangxue]

I think we can take this change because the existing code turns Post[1] into Post[1], which isn't a valid ID anyway. So this change is more like fixing a previously undefined/improper result.

[samdark]

Technically it is valid in HTML5 but it's not a good practice because of JS and CSS issues with such IDs. Agree that it's more like a fix.

[cebe]

but if it is valid in HTML5 it generated valid ids before so changing it may break code that was relying on the ids...

[qiangxue]

Any suggestion? Or perhaps we can let it slip in the release since it's very unlikely that someone would use such IDs...

[qiangxue]

Also Post[1] is not a valid camelcase word either...

[samdark]

Why it replaces [] only then and not everything that is not valid?

[qiangxue]

Yes, it could.

[aleksanderd]

I written before I not sure how to make this. I just needed a tool to make IDs from long names in my custom widgets. There is Html::getInputId, but it accepts $model+$attribute so I can not use a ready $name to get $id. For me it is enough just to have separated function which not depend on a model.

camel2id seems to be ok too, but now I not sure what and how other invalid chars must be replaced, and more matters is that Post[1] is not camel, so even function name will be wrong...

[aleksanderd]

btw, what is BC? :)

[alex-code]

BC means backwards compatibility.

[aleksanderd]

thnx Alex! :)

what about to introduce name2camel()?
for my case it will be used like camel2id(name2camel($name))

[klimov-paul]

Should not Inflector::slug() should be used here?

[coveralls]

Changes Unknown when pulling c27a5f7 on flyiing:6131-dumb into * on yiisoft:master*.

[SilverFire]

Seems to be outdated. Agreed with @klimov-paul