Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTML Imports to Yii2's AssetBundle system #8121

Closed
wants to merge 1 commit into from

Conversation

navarr
Copy link
Contributor

@navarr navarr commented Apr 19, 2015

This pull request is a Feature Request for supporting HTML imports. This is a browser technology that is currently being implemented and has available polyfills.

This PR adds HTML Import specific knowledge to asset bundles so that they may declare HTML imports. This is especially useful for any platform that wishes to make use of Polymer

Status of native browser implementation of the feature


Imports are last on the list so that the required webcomponents.js can be included before the imports.

@samdark
Copy link
Member

samdark commented Apr 19, 2015

That's Chrome-specific and as far as I understand, has no specification. Not sure if it will be ever implemented everywhere and if it's a good idea to have it in the framework core.

@navarr
Copy link
Contributor Author

navarr commented Apr 19, 2015

It is currently Chrome specific in native implementation, however the use case I created this for works with all Evergreen browsers (Polymer)

There is a spec: http://w3c.github.io/webcomponents/spec/imports/

It is implemented in Firefox behind a flag and is under consideration by IE.

It's also in Opera

@samdark samdark self-assigned this Apr 19, 2015
@samdark samdark added this to the 2.0.x milestone Apr 19, 2015
@navarr
Copy link
Contributor Author

navarr commented May 11, 2015

Been "under discussion" for 22 days. Is anything else needed from me to advance this?

@samdark
Copy link
Member

samdark commented May 11, 2015

I tend to discard the pull request since it's not generic enough. @yiisoft/core-developers opinions?

@qiangxue
Copy link
Member

I tend to discard the pull request since it's not generic enough. @yiisoft/core-developers opinions?
Show all checks

Agree.

@samdark samdark closed this May 12, 2015
@cebe cebe removed this from the 2.0.x milestone May 12, 2015
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e1ca678 on navarr:html-imports into ** on yiisoft:master**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants