Add comment method to SchemaBuilder #9089
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mment('Definition');
|
|
|
I got it just now, should I fix that by implementing |
|
Yes. |
|
It works on postgress? |
|
I have not tested it on postgre, but as I know postgre has another writing rules about comments on columns |
|
@nemmo yes. It does not work on postgre. But your method must be a cross platform. |
|
Explain |
| */ | ||
| protected function buildCommentString() | ||
| { | ||
| return $this->comment === null ? '' : " COMMENT '{$this->comment}'"; |
This was referenced Aug 6, 2015
|
PR can't be merged because it's MySQL only and has issues. |
|
Implemented in fde8aa6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schema::integer()->comment('Definition');