DI injection via method signature

[mdmunir]

#9476 I hope i am doing right.

[kathysledge]

👍 Looks good. Could you add the following to the tests?

$result = $controller->runAction('aksi5', $params);
$this->assertEquals(['d426', 'independent', 'other_qux'], $result);
...
public function actionAksi5($q, Bar $bar, QuxInterface $quxApp)
{
    return [$q, $bar->foo, $quxApp->quxMethod()];
}

[samdark]

In #9476 I've meant general purpose method injection, not necessary controller but probably it's OK.

[samdark]

It's better to move these into separate files.

[mdmunir]

@samdark ya i know. But how to do that?

class MyObj extends Object
{
    public function test(Cache $cache)
    {
        $cache->set();
    }
}

$obj = new MyObj();
$obj->test(); // <- will always error

Other scenario

class MyObj extends Object
{
    protected function test(Cache $cache) // as protected
    {
        $cache->set();
    }

    public __call($name,$args)
    {
        $ref = getReflectionMethod($name);
        $args = injectArgument($ref,$args);
        return call_function_array([$this,$name],$args);
    }
}

$obj = new MyObj();
$obj->test(); 

I am not sure its a good scenario

[kathysledge]

I think one-step at a time. First get it working well with controller actions and the modified tests passing. Then it can be put through its paces after merging. Once that is stable, some thought can be put in to a more generic method version. Just my 2¢.

[mdmunir]

@df2 do you need another test before i add new commit?

[samdark]

Agree.

[kathysledge]

@mdmunir I was just thinking the one above with the url parameter first and then the service variables.

[samdark]

Overall it works well. One thing is, for example, if I define method signature like the following

public function actionIndex(BooleanValidator $validator)

and then pass ?validator=123 via request, Yii raises an exception. I think if an argument is type-hinted, it should not receive any value.

[samdark]

Better to use $class instead of $c.

[samdark]

Also $type could be renamed to $className.

[mdmunir]

@samdark I think the same. Prefer change the order of checking. Check type at first before $params avaliable.

            $name = $param->getName();
            if (($class = $param->getClass()) !== null) {
                $className = $class->getName();
                if (Yii::$app->has($name) && ($obj = Yii::$app->get($name)) instanceof $className) {
                    $args[] = $actionParams[$name] = $obj;
                }else{
                    $args[] = $actionParams[$name] = Yii::$container->get($className);
                }
            }elseif (array_key_exists($name, $params)) {
                if ($param->isArray()) {
                    $args[] = $actionParams[$name] = (array) $params[$name];
                } elseif (!is_array($params[$name])) {
                    $args[] = $actionParams[$name] = $params[$name];
                } else {
                    throw new BadRequestHttpException(Yii::t('yii', 'Invalid data received for parameter "{param}".', [
                        'param' => $name,
                    ]));
                }
                unset($params[$name]);

[samdark]

Yep. The case I've described should be tested.

[mdmunir]

    // FakeController
    public function actionAksi6($q, EmailValidator $validator)
    {
        return [$q, $validator->validate($q), $validator->validate('misbahuldmunir@gmail.com')];
    }

    // Test
    $params = ['fromGet'=>'from query params','q'=>'d426','validator'=>'avaliable'];
    $result = $controller->runAction('aksi6', $params);
    $this->assertEquals(['d426', false, true], $result);

?

[samdark]

Yes.

[andre487]

Missing \n?

[samdark]

The code looks OK to me now (except really minor formatting issues). @mdmunir do you want to attempt extending DI docs?

[mdmunir]

You do @samdark, i am not good in english 😀

[samdark]

OK.

[samdark]

Found another thing. While web controllers are good we haven't covered console controllers.

[mdmunir]

Ya, i miss it. Should i take it in this PR or create new PR?

[samdark]

This one is OK.

[samdark]

Merged b702006. Thank you!

[coveralls]

Changes Unknown when pulling 51887c8 on mdmunir:9476-di-via-method-signature into ** on yiisoft:master**.