fix: allow users to set the physics client correctly #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to the importing of the module level CLIENT variable, the set_client functionality in shared_const.py does not work, meaning you are unable to set the client that the planning libraries operate on. This means you need to load the planning client first which is a pain and error prone.
I have updated all references of CLIENT to get_client() which gets the correct client from the shared_consts once set_client has been called.
Rather than passing in the physicsClientId to all the pybullet commands, it should instead use the BulletClient class which was designed specifcally for this purpose, but this would have been too drastic a change for this commit.