Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish onto extensions.gnome.org? #145

Open
Fenimoure opened this issue Nov 30, 2023 · 15 comments · May be fixed by #152
Open

Publish onto extensions.gnome.org? #145

Fenimoure opened this issue Nov 30, 2023 · 15 comments · May be fixed by #152

Comments

@Fenimoure
Copy link

It would be pretty nice to have this extension available that way. thanks.

@khaustovdn
Copy link

yes, please

@Aworldc
Copy link

Aworldc commented Dec 5, 2023

@cfouche3005
Copy link

I think he mean publish the update to extensions.gnome.org

@zbikk
Copy link

zbikk commented Dec 6, 2023

is there anything stopping the upload of the new version to the site?

@leaf-penguin
Copy link

leaf-penguin commented Dec 31, 2023

is there anything stopping the upload of the new version to the site?

Looks like v12 was pushed to the gnome extensions website but the update was rejected. The issues seem pretty small.

https://extensions.gnome.org/review/47995

@benjamin051000
Copy link

This is kind of a duplicate of #147 by the way. Just linking the two together. :)

@benjamin051000
Copy link

benjamin051000 commented Dec 31, 2023

Here's a copy of the rejection notes (see link @leaf-penguin posted above):

  1. No need to use this.initTranslation() (line 18 prefs.js):

    Consider this method deprecated.
    Only specify gettext-domain in metadata.json.
    GNOME Shell can automatically initiate the translation for you
    when it sees the gettext-domain key in metadata.json.

    Port Guide 45: Extension Utils

  2. You should uninit_settings() in disable() and window close request in prefs.js.

    window.connect('close-request', () => {
        uninit_settings();
    });

@devNamanG
Copy link

Is it expected to be fixed soon?
Or are any PRs open for it?

@AJCxZ0
Copy link

AJCxZ0 commented Jan 10, 2024

What can we do to help make this happen? I am tired of snagging things on the sharp corners of my windows.

@devNamanG
Copy link

What can we do to help make this happen?

So basically you can follow the steps in the README and compile and install on your machine, I did the same, it's temporary till the extension comes up as supported on EGO for Shell v45.

@AJCxZ0
Copy link

AJCxZ0 commented Jan 14, 2024

Thank you for the advice, @namangor04.

So basically you can follow the steps in the README...

Please excuse me for being insufficiently clear. By "this" I meant the purpose stated in the issue, i.e. to publish on Rounded Window Corners so that it gets automagically picked up and updated on GNOME 45+.

@coolkys
Copy link

coolkys commented Jan 15, 2024

I guess someone could follow the feedback in the rejection note and make a PR, then wait for the author to approve and re-push to gnome extensions.
However, by the looks of things on this repo, I think the author is either busy with life, or otherwise MIA.

@in4matix
Copy link

in4matix commented Jan 15, 2024

For anyone interested I have packed 63 various extensions, including RWC, that are compatible with Gnome 45.2 in a repo. (https://github.com/in4matix/Gnome45-Extensions)

@coolkys
Copy link

coolkys commented Jan 16, 2024

For anyone interested I have packed 63 various extensions, including RWC, that are compatible with Gnome 45.2 in a repo. (https://github.com/in4matix/Gnome45-Extensions)

Your repo should be the de facto way to install this extension in Gnome 45 for now. Thanks!

@Memnoc
Copy link

Memnoc commented Jan 31, 2024

For anyone interested I have packed 63 various extensions, including RWC, that are compatible with Gnome 45.2 in a repo. (https://github.com/in4matix/Gnome45-Extensions)

Thanks for the time spent doing this, I have starred your repo and was missing this extension to run alacritty with no decoration and the same gnome rounded corners I have in Debian

@toolstack toolstack linked a pull request Feb 10, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.