Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

处理直接使用 String.prototype.length 对码点大于U+010000的字符不正确的问题 #111

Merged
merged 7 commits into from Jul 18, 2018
Merged

处理直接使用 String.prototype.length 对码点大于U+010000的字符不正确的问题 #111

merged 7 commits into from Jul 18, 2018

Conversation

fanerge
Copy link
Contributor

@fanerge fanerge commented Jul 10, 2018

处理直接使用 String.prototype.length 对码点大于U+010000的字符不正确的问题
"aaaa".lenght === 3
"𠮷𠮷𠮷".lenght !== 3

@fanerge
Copy link
Contributor Author

fanerge commented Jul 10, 2018

初次PR，不知道有没有弄对

@coveralls
Copy link

coveralls commented Jul 10, 2018 •
edited

Coverage Status

Coverage remained the same at 88.235% when pulling 057c404 on fanerge:master into e782748 on yiminghe:master.

@yiminghe
Copy link
Owner

test case

@yiminghe yiminghe merged commit 0722d0d into yiminghe:master Jul 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fanerge @coveralls @yiminghe