feat: don't use console.warn in node env #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-horse
commented
Apr 21, 2017
| @@ -3,7 +3,8 @@ const formatRegExp = /%[sdj%]/g; | |||
| let warning2 = () => { | |||
| }; | |||
|
|
|||
| if (process.env.NODE_ENV !== 'production') { | |||
| // don't print warning message when in production env or node runtime | |||
| if (process.env.NODE_ENV !== 'production' && typeof global === 'undefined') { | |||
There was a problem hiding this comment.
是否有更好的区分前后端运行时的方式？ @yiminghe
There was a problem hiding this comment.
有些同构的解决方案，是不是会在 node 全局注入一个 window 对象？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.