Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust elRegion instead of refNodeRegion #14

Merged
merged 1 commit into from May 3, 2017

Conversation

RaoHai
Copy link
Contributor

@RaoHai RaoHai commented Apr 12, 2017

No description provided.

@RaoHai RaoHai mentioned this pull request Apr 12, 2017
@coveralls
Copy link

Coverage Status

Coverage remained the same at 67.087% when pulling cfe419d on RaoHai:viewport-adjust into 126c373 on yiminghe:viewport-adjust.

@RaoHai
Copy link
Contributor Author

RaoHai commented Apr 14, 2017

@benjycui

@benjycui
Copy link
Collaborator

👍

本地 link 测试,没有明显 bug

@benjycui
Copy link
Collaborator

但是好像把这个分支的代码也带进去了 https://github.com/yiminghe/dom-align/tree/target-out-of-view

@benjycui
Copy link
Collaborator

@yiminghe 要不你吧这个 PR 合了,但是不发版本,我下周把 antd@0.12.x 的那个问题解决后再一并发布?

@benjycui
Copy link
Collaborator

benjycui commented May 3, 2017

ping~

@yiminghe yiminghe merged commit 474932b into yiminghe:viewport-adjust May 3, 2017
@benjycui
Copy link
Collaborator

benjycui commented May 4, 2017

这个不先合到 master 上么。。分支有点多,不知道基于哪个开发。

@yiminghe
Copy link
Owner

yiminghe commented May 4, 2017

在 viewport-adjust 搞吧,发布前合到 master 吧

@benjycui
Copy link
Collaborator

那么 target-out-of-view 分支可以先删除了,毕竟已经合并进 viewport-adjust 了。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants