Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GAM plots with nominal interaction terms #7

Open
sds-dubois opened this issue Mar 9, 2016 · 2 comments
Open

GAM plots with nominal interaction terms #7

sds-dubois opened this issue Mar 9, 2016 · 2 comments

Comments

@sds-dubois
Copy link

It seems to me that there is a bug in Visualizer when one of the interaction terms is not of type BinnedAttribute, because at line 251 there is a cast Bins bins1 = ((BinnedAttribute) f1).getBins(); without a previous type test. This is weird because some tests are made before to handle NominalAttributes, but the end of the code seems to run only on BinnedAttributes (in particular it need boundaries which are only defined for bins..).

@yinlou
Copy link
Owner

yinlou commented Mar 10, 2016

The code was initially designed to support both BinnedAttribute and NominalAttribute, but at some point I was focusing on BinnedAttribute. I will fix that in the next iteration. Thanks for point that out!

@sds-dubois
Copy link
Author

I tried to fix it, and was able to do it when both are discrete but couldn't do what I wanted with gnuplot when one is discrete and one is continuous. So I actually decided to use ggplot in R, and to call my R scripts from Java. If you're interested you can see what I did on my fork (check the branch selectFeatures).

Here is an example of the new plots:
new_plots2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants