Use get_template_directory_uri for fetching the account icon #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm merging this pull request and work to spread the fix to the whole theme because we have this issue on every pattern. Thanks for this report and hint! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating a child theme for wonder I got this error saying that it could not find the account-icon in the header of the child theme. On exploring a bit I found that
get_theme_file_uriwas returning the child theme directory which would not contain theassets. This was an issue that was faced by TT2 as well which was fixed later on, attaching the TT2 fix PRWordPress/twentytwentytwo#283. This PR does the same fix for account-icon.