Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preliminary Fluid Type support #5

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Add preliminary Fluid Type support #5

merged 1 commit into from
Oct 3, 2022

Conversation

0aveRyan
Copy link
Contributor

@0aveRyan 0aveRyan commented Sep 6, 2022

Opts-in to Fluid Typography feature with more proportional responsive collapse of font sizes.

Making note some templates still have fixed sizes, we should explore perhaps adding one final font size to address some of the current 4rem sizes in templates.

@francgrasso francgrasso merged commit 5f9a94c into yithemes:master Oct 3, 2022
@francgrasso
Copy link
Member

Thanks @0aveRyan ! I've approved it only now and not earlier because WP 6.1 release date is really near.

@0aveRyan
Copy link
Contributor Author

0aveRyan commented Oct 3, 2022

Hey @francgrasso,

I'm currently out-of-office but would love to touch base on this and a few other Wonder things when I return in a few weeks! Fluid typography is a progressive enhancement so even a 6.0 or lower Core install should remain as-is but 6.1 users will get a slightly-improved experience. I'd love to get Sara to refine these! I was fairly conservative with my measurement tweaks and she can certainly bring some better design thinking 🙂 Have a few other things I'd love to get your thoughts on and on your radar! I'll send you both a ping when I'm back from vacation ✌️

@francgrasso
Copy link
Member

Sure! Let's update once you're back! Enjoy your holidays for the moment 😄😉

@0aveRyan 0aveRyan deleted the add/fluid-typography branch December 8, 2022 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants