#65 admin/promo/create #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yitsushi
requested changes
Oct 9, 2023
| promo.CreateRequest{NoteID: "8zwxx3cpy9", ExpiresAt: time.Now().Add(86400 * 24 * time.Hour).Unix()}, | ||
| }, | ||
| ) | ||
| } |
There was a problem hiding this comment.
Can you please add an example in the test, like other endpoints has? That way we always have simple examples for all endpoints that can be copy pasted if someone wants to play around.
There was a problem hiding this comment.
Have added an example of creating a promo request, following the example.
|
Have updated to fix the golint and golang-ci-lint issues. |
|
Have also added an example of creating a promo request. |
yitsushi
approved these changes
Oct 20, 2023
yitsushi
reviewed
Oct 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Implemented an endpoint (/api/admin/promo/create) for an admin to create a promo for a note.
Issue or RFC
Issue #65
Documentation: https://misskey.io/api-doc#tag/admin
Alternate Designs
Possible Drawbacks
Verification Process
Unit test for creating a promo.
Release Notes
Created an endpoint for admin to promo a note.