fix linting issues

Signed-off-by: Efertone <efertone@pm.me>

.github/workflows/quality-check.yaml

@@ -15,7 +15,7 @@ jobs:
       - name: Set up Go 1.x
         uses: actions/setup-go@v3
         with:
-          go-version: ^1.19
+          go-version: ^1.20
 
       - name: Get dependencies
         run: |
@@ -43,7 +43,7 @@ jobs:
       - name: Set up Go 1.x
         uses: actions/setup-go@v3
         with:
-          go-version: ^1.19
+          go-version: ^1.20
 
       - name: Get dependencies
         run: |
@@ -66,4 +66,4 @@ jobs:
       - name: golangci-lint
         uses: golangci/golangci-lint-action@v3
         with:
-          version: v1.51.0
+          version: v1.52.0

.golangci.yml

@@ -47,14 +47,16 @@ issues:
   - path: internal/cmd/
     linters:
     - forbidigo
+  - text: "sig: func github.com/yitsushi/totp-cli/"
+    linters:
+    - wrapcheck
+  - text: "sig: func \\(\\*?github.com/yitsushi/totp-cli/"
+    linters:
+    - wrapcheck
 
 linters:
   enable-all: true
   disable:
-    # Go Generics
-    - rowserrcheck
-    - sqlclosecheck
-    - wastedassign
     # Deprecated
     - interfacer
     - nosnakecase

app.go

@@ -5,6 +5,7 @@ import (
 	"os"
 
 	"github.com/urfave/cli/v2"
+
 	"github.com/yitsushi/totp-cli/internal/cmd"
 	"github.com/yitsushi/totp-cli/internal/info"
 )

go.mod

@@ -1,6 +1,6 @@
 module github.com/yitsushi/totp-cli
 
-go 1.19
+go 1.20
 
 require (
 	filippo.io/age v1.1.1

internal/cmd/change_password.go

@@ -1,7 +1,6 @@
 package cmd
 
 import (
-	"fmt"
 	"os"
 
 	"github.com/urfave/cli/v2"
@@ -38,16 +37,12 @@ func ChangePasswordCommand() *cli.Command {
 			}
 
 			if !CheckPasswordConfirm([]byte(newPasswordIn), []byte(newPasswordConfirmIn)) {
-				return fmt.Errorf("New Password and the confirm mismatch!")
+				return CommandError{Message: "new password and the confirm mismatch"}
 			}
 
 			storage.Password = newPasswordIn
 
-			if err = storage.Save(); err != nil {
-				return err
-			}
-
-			return nil
+			return storage.Save()
 		},
 	}
 }

internal/cmd/const.go

@@ -5,7 +5,7 @@ const (
 	argPositionAccount   = 1
 	argPositionPrefix    = 2
 
-	strictDumpFilePerms = 0600
-
 	binaryChmodValue = 0o755
+
+	strictDumpFilePerms = 0o600
 )

internal/cmd/dump.go

@@ -1,6 +1,7 @@
 package cmd
 
 import (
+	"fmt"
 	"os"
 
 	"github.com/urfave/cli/v2"
@@ -11,6 +12,7 @@ import (
 
 func DumpCommand() *cli.Command {
 	warningMsg := "The output is NOT encrypted. Use this flag to verify you really want to dump all secrets."
+
 	return &cli.Command{
 		Name:      "dump",
 		Usage:     "Dump all available accounts under all namespaces.",
@@ -41,11 +43,11 @@ func DumpCommand() *cli.Command {
 
 			out, err := yaml.Marshal(storage.Namespaces)
 			if err != nil {
-				return err
+				return fmt.Errorf("failed to marshal storage: %w", err)
 			}
 
 			if err := os.WriteFile(ctx.String("output"), out, strictDumpFilePerms); err != nil {
-				return err
+				return fmt.Errorf("failed to write output file: %w", err)
 			}
 
 			return nil

internal/cmd/generate.go

@@ -18,7 +18,7 @@ func GenerateCommand() *cli.Command {
 			&cli.BoolFlag{
 				Name:  "follow",
 				Value: false,
-				Usage: "Generate codes continously.",
+				Usage: "Generate codes continuously.",
 			},
 		},
 		Usage:     "Generate a specific OTP",

internal/cmd/list.go

@@ -17,7 +17,7 @@ func ListCommand() *cli.Command {
 		Action: func(ctx *cli.Context) error {
 			storage, err := s.PrepareStorage()
 			if err != nil {
-				return nil
+				return err
 			}
 
 			ns := ctx.Args().Get(argPositionNamespace)