docs: fix typos #104
Merged
docs: fix typos #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Found via `typos --hidden --format brief` and `codespell -i3 -w -H`
|
Thank you |
|
🥳 🥳 🥳 🥳 🥳 |
nuxi
reviewed
Jan 24, 2024
| @@ -40,7 +40,7 @@ type Storage struct { | |||
| Namespaces []*Namespace | |||
| } | |||
|
|
|||
| // DecryptV1 tries to decrypt the original unsecure SHA1 storage. | |||
There was a problem hiding this comment.
this wasn't actually a typo, thats literally what the function is named
https://github.com/yitsushi/totp-cli/blob/main/internal/security/unsecure.go
(Whether that function name was a typo is another question)
There was a problem hiding this comment.
That's true, and with the new wording it implies the storage itself was SHA1 "encrypted" (which is not an encryption, it's a hashing algo). But in all cases, this comment is not valid at all. It does not try to "decrypt the original unsecure SHA1 storage", it tries to decrypt using the old method (UnsecureSHA1) of hashish of the password. :/
There was a problem hiding this comment.
This should make it a bit more clear: #111
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via
typos --hidden --format briefandcodespell -i3 -w -H