refactor: cleanup, mostly tests #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for more work, related to #112, #37 and #8. - Migrated all tests to use testify's `Suite` instead of direct `assert` calls. - Simplified how the credentials file location is determined, now it's defined in one simple function. Changes I may revert: I hate string concatenation, it's just ugly in my eyes, so I may just add that linter to disabled and revert to `Sprintf`. I know it's more efficient, but not on this scale. Closes #8 References: - #8 - #37 - #112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for more work, related to #112, #37 and #8.
Suiteinstead of directassertcalls.Changes I may revert: I hate string concatenation, it's just ugly in my eyes, so I may just add that linter to disabled and revert to
Sprintf. I know it's more efficient, but not on this scale.Closes #8
References: