Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

source code question #14

Open
kai-xie opened this issue Jul 20, 2017 · 0 comments
Open

source code question #14

kai-xie opened this issue Jul 20, 2017 · 0 comments

Comments

@kai-xie
Copy link

kai-xie commented Jul 20, 2017

Hi,
Thanks for your work!
I found that the code in the file compress_inner_product_layer.cpp, line 139, 140, 145, and 146, might be problematic.
this->mu += fabs(weight[k]);
this->std += weight[k]*weight[k];

this->mu += fabs(bias[k]);
this->std += bias[k]*bias[k];

Should they be the following? With the “mask” multiplied.
this->mu += fabs(weight[k]* weightMask[k]);
this->std += weight[k]*weight[k* weightMask[k]];

this->mu += fabs(bias[k]* biasMask[k]);
this->std += bias[k]*bias[k]* biasMask[k];

Thanks,
Kai

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant