-
Notifications
You must be signed in to change notification settings - Fork 102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Division by zero in Cauchy.h #18
Comments
Thanks for the report. I'm a bit busy recently, but I'll look into this issue when I get some time. |
I read the original paper on L-BFGS-B again, and noticed that |
Here is an example modified from
|
This issue has been fixed in 880a8da. |
Dear Yixuan,
Thanks for sharing the great code. I found that in some rare cases, the variable
fpp
inCauchy.h
may happen to be zero, which leads to NaN results:LBFGSpp/include/LBFGSpp/Cauchy.h
Line 243 in 8dd1b51
The text was updated successfully, but these errors were encountered: