feat(core): allow undefined config

yjl9903 · Feb 27, 2024 · 2ef4cd1 · 2ef4cd1
1 parent e30e47f
commit 2ef4cd1
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 8 deletions.
diff --git a/packages/core/src/providers/clarity.ts b/packages/core/src/providers/clarity.ts
@@ -3,12 +3,14 @@ import type { ScriptTag } from '../tag';
 export const ClarityKey = 'clarity';
 
 export interface ClarityOptions {
-  id: string;
+  id: string | undefined;
 }
 
-export function Clarity(options: ClarityOptions): ScriptTag {
+export function Clarity(options: ClarityOptions): ScriptTag | undefined {
   const id = options.id;
 
+  if (!id) return undefined;
+
   return {
     type: `text/javascript`,
     children: `(function(c,l,a,r,i,t,y){

diff --git a/packages/core/src/providers/cloudflare.ts b/packages/core/src/providers/cloudflare.ts
@@ -8,13 +8,15 @@ export interface CloudflareOptions {
    */
   src?: string;
 
-  beacon: string;
+  beacon: string | undefined;
 }
 
-export function Cloudflare(options: CloudflareOptions): ScriptTag {
+export function Cloudflare(options: CloudflareOptions): ScriptTag | undefined {
   const src = options.src ?? `https://static.cloudflareinsights.com/beacon.min.js`;
   const beacon = options.beacon;
 
+  if (!beacon) return undefined;
+
   return {
     src,
     defer: true,

diff --git a/packages/core/src/providers/plausible.ts b/packages/core/src/providers/plausible.ts
@@ -8,13 +8,15 @@ export interface PlausibleOptions {
    */
   src?: string;
 
-  domain: string;
+  domain: string | undefined;
 }
 
-export function Plausible(options: PlausibleOptions): ScriptTag {
+export function Plausible(options: PlausibleOptions): ScriptTag | undefined {
   const src = resolveSrc(options.src ?? `https://plausible.io/js/script.js`);
   const domain = options.domain;
 
+  if (!domain) return undefined;
+
   return {
     src,
     defer: true,

diff --git a/packages/core/src/providers/umami.ts b/packages/core/src/providers/umami.ts
@@ -8,13 +8,15 @@ export interface UmamiOptions {
    */
   src?: string;
 
-  id: string;
+  id: string | undefined;
 }
 
-export function Umami(options: UmamiOptions): ScriptTag {
+export function Umami(options: UmamiOptions): ScriptTag | undefined {
   const src = resolveSrc(options.src ?? `https://us.umami.is/script.js`);
   const websiteId = options.id;
 
+  if (!websiteId) return undefined;
+
   return {
     src,
     defer: true,