Skip to content

Commit

Permalink
feat: client may be undefined
Browse files Browse the repository at this point in the history
  • Loading branch information
yjl9903 committed Mar 22, 2024
1 parent 5565158 commit d76a13d
Show file tree
Hide file tree
Showing 3 changed files with 19 additions and 17 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,7 @@ import { umami } from '~analytics/umami';

document.querySelector('.umami')?.addEventListener('click', () => {
// Track events
umami.track('click umami button');
umami?.track('click umami button');
});
```

Expand Down
2 changes: 1 addition & 1 deletion examples/vite/main.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { umami } from '~analytics/umami';

document.querySelector('.umami')?.addEventListener('click', () => {
umami.track('click umami button');
umami?.track('click umami button');
});
32 changes: 17 additions & 15 deletions packages/unplugin-analytics/client.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ declare module '~analytics/scripts.astro' {
}

declare module '~analytics/clarity' {
export const clarity: (event: string) => void;
export const clarity: ((event: string) => void) | undefined;
}

declare module '~analytics/umami' {
Expand All @@ -17,21 +17,23 @@ declare module '~analytics/umami' {
website: string;
};

export const umami: {
track: {
(): Promise<string>;
export const umami:
| {
track: {
(): Promise<string>;

(payload: Payload): Promise<string>;
(payload: Payload): Promise<string>;

(
payload: (
props: Payload
) =>
| (Payload & { name: string; data: Record<string, any> })
| (Payload & Record<string, any>)
): Promise<string>;
(
payload: (
props: Payload
) =>
| (Payload & { name: string; data: Record<string, any> })
| (Payload & Record<string, any>)
): Promise<string>;

(event: string, data?: Record<string, any>): Promise<string>;
};
};
(event: string, data?: Record<string, any>): Promise<string>;
};
}
| undefined;
}

0 comments on commit d76a13d

Please sign in to comment.