Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update peer dependencies package.json #151

Closed
wants to merge 1 commit into from
Closed

Conversation

websiddu
Copy link

No description provided.

@hoebbelsB
Copy link

why isn't this merged? prosemirror-model 1.7 was released 5 years ago. The most recent version is 1.2.0. Because they messed up their versioning, we are always facing the following warning

image

This PR would fix that issue :)

@dmonad
Copy link
Member

dmonad commented Apr 27, 2024

I'm very happy to fix warning messages. But I didn't know about this one. Should I? Who throws it?

I don't understand why I should update peer-dependencies if I didn't break compatibility with the mentioned packages.

y-prosemirror is still compatible with prosemirror-model 1.7.0 (yes, the one that was released 5 years ago). But y-prosemirror is also compatible with prosemirror-model 1.20.0 (the latest release). ^1.7.0 should match 1.20.0 (semantic versioning).

@dmonad
Copy link
Member

dmonad commented Apr 27, 2024

why isn't this merged? prosemirror-model 1.7 was released 5 years ago. The most recent version is 1.2.0. Because they messed up their versioning, we are always facing the following warning

image

This PR would fix that issue :)

Okay. I think you misunderstand who causes this issue. The warning message literally says that you are using an old version of prosemirror-model.

The latest release of prosemirror-model is 1.20.0 (not 1.2.0, that one is even older). Prosemirror also didn't mess up versioning. You did 😉

I don't see a need to update my peer-dependencies.

@dmonad dmonad closed this Apr 27, 2024
@hoebbelsB
Copy link

@dmonad thanks for pointing that one out, sorry for the confusion 🤦

@dmonad
Copy link
Member

dmonad commented Apr 28, 2024

Np, that happens 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants