Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

YEvent.changes typing is incomplete #232

Closed
2 tasks done
rideg opened this issue Aug 24, 2020 · 0 comments · Fixed by #233
Closed
2 tasks done

YEvent.changes typing is incomplete #232

rideg opened this issue Aug 24, 2020 · 0 comments · Fixed by #233
Assignees
Labels

Comments

@rideg
Copy link
Contributor

rideg commented Aug 24, 2020

Please save me some time and use the following template. In 90% of all issues I can't reproduce the problem because I don't know what exactly you are doing, in which environment, or which y-* version is responsible. Just use the following template even if you think the problem is obvious.

Checklist

Describe the bug
YEvent.changes does not have typing for the keys property

To Reproduce
Try to run code completion in VSCode or with YouCompleteMe in Vi while using Typescript

Expected behavior
The keys property should be available for code completion

Screenshots
Screen Shot 2020-08-24 at 9 51 05 AM

Environment Information
"yjs": "^13.3.2"

Additional context
Add any other context about the problem here.

@rideg rideg added the bug label Aug 24, 2020
dmonad added a commit that referenced this issue Sep 28, 2020
Amend typing of YEvent.changes, fixes #232
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants